Provide a Display API for string_view via .display()#515
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Provide a Display API for string_view via .display()#515copybara-service[bot] wants to merge 1 commit intomainfrom
.display()#515copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
As discussed in the API Review, we'd like to start by not implementing Display directly, but rather providing it through a proxy method `.display()`. This provides us with an easy avenue to implement Display directly in the future if we decide we want to (whereas going the other way would be much more difficult). This CL also extracts the shared Display implementation for `string` and `string_view` to a `LossyUtf8Display` struct. PiperOrigin-RevId: 873138034
copybara-service
bot
force-pushed
the
test_873138034
branch
from
54c1789 to
04b51d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a Display API for string_view via
.display()As discussed in the API Review, we'd like to start by not implementing Display directly, but rather providing it through a proxy method
.display(). This provides us with an easy avenue to implement Display directly in the future if we decide we want to (whereas going the other way would be much more difficult).This CL also extracts the shared Display implementation for
stringandstring_viewto aLossyUtf8Displaystruct.