Skip to content

Integrate LLVM at llvm/llvm-project@fbfe23e16d5e #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −10
Open

Integrate LLVM at llvm/llvm-project@fbfe23e16d5e #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/llvm.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _llvm_loader_repository(repository_ctx):
executable = False,
)

LLVM_COMMIT_SHA = "b20d7d0278059735bb8eb538ac51e13b58895c1a"
LLVM_COMMIT_SHA = "fbfe23e16d5e49c9decccc981a4716e7cf81d242"

def llvm_loader_repository_dependencies():
# This *declares* the dependency, but it won't actually be *downloaded* unless it's used.
Expand Down
12 changes: 3 additions & 9 deletions lifetime_analysis/test/control_flow.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,7 @@ TEST_F(LifetimeAnalysisTest, ReturnRefArgumentWithConditionalOperator) {
LifetimesAre({{"get_lesser_of", "a, a -> a"}}));
}

TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWorkSometimes) {
// This test documents that we do understand the control flow resulting from
// exceptions in some limited circumstances. However, this is not true in the
// general case -- see the test ControlFlowExceptionsNotSupportedInGeneral --
// and it's a non-goal to add support for this.
TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWithUnconditionalThrow) {
EXPECT_THAT(GetLifetimes(R"(
int* target(int* a, int* b) {
try {
Expand All @@ -61,9 +57,7 @@ TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWorkSometimes) {
LifetimesAre({{"target", "a, b -> b"}}));
}

TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsNotSupportedInGeneral) {
// This test documents that we do not in general treat the control flow
// resulting from exceptions correctly; changing this is a non-goal.
TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsWithUnknownControlFlow) {
EXPECT_THAT(GetLifetimes(R"(
void may_throw() {
throw 42;
Expand All @@ -77,7 +71,7 @@ TEST_F(LifetimeAnalysisTest, ControlFlowExceptionsNotSupportedInGeneral) {
}
}
)"),
LifetimesContain({{"target", "a, b -> a"}}));
LifetimesContain({{"target", "a, a -> a"}}));
}

TEST_F(LifetimeAnalysisTest, DoublePointerWithConditionalAssignment) {
Expand Down