Replace LazilyLoadedFileReadCallback with ReaderSeeker#2182
Merged
Databean merged 2 commits intogoogle:mainfrom Feb 25, 2026
Merged
Replace LazilyLoadedFileReadCallback with ReaderSeeker#2182Databean merged 2 commits intogoogle:mainfrom
Databean merged 2 commits intogoogle:mainfrom
Conversation
This allows reusing any ReaderSeeker implementation together with LazilyLoadedFile. Bug: b/487500218
This makes it possible to use `SeekingZipSource`s in places that expect to receive `std::unique_ptr<ReaderSeeker>` implementations. It would also be possible to call `SeekingZipSource::Reader()` directly, but `ZipSourceAsReaderSeekerImpl` is self-contained, while the `Reader()` value on its own assumes the `SeekingZipSource` instance is still alive in the background. Bug: b/487500218
cjreynol
approved these changes
Feb 25, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows reusing any ReaderSeeker implementation together withLazilyLoadedFile.
This also makes it possible to use
SeekingZipSources in places that expect to receivestd::unique_ptr<ReaderSeeker>implementations. It would also be possible to callSeekingZipSource::Reader()directly, butZipSourceAsReaderSeekerImplis self-contained, while theReader()value on its own assumes theSeekingZipSourceinstance is still alivein the background.
Bug: b/487500218