This repository was archived by the owner on Nov 7, 2024. It is now read-only.
Open
Conversation
mganahl
suggested changes
Apr 2, 2021
Contributor
mganahl
left a comment
mganahl
left a comment
There was a problem hiding this comment.
Please also add pinv to all other backends, or raise a NotImplementedError,
and add tests for each function. Thanks!
| Returns: | ||
| tensor: The pseudo inverse of tensor. | ||
| """ | ||
| return np.linalg.pinv(tensor) No newline at end of file |
Contributor
There was a problem hiding this comment.
you should use the tensorflow version here
Author
There was a problem hiding this comment.
Hi.
In a StackOverflow article someone has mentioned that the Tensorflow version doesn't work for complex matrices and that's why I went with the Numpy Version.
So shall I still use the Tensorflow version only?
Contributor
There was a problem hiding this comment.
yes, please use tensorflow. The point here is to use backend-native operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done with respect to issue: #844
pinvfunction is added totensornetwork/backends/tensorflow/numpy_backend.pyThe
pinvfunction has been referred from https://numpy.org/doc/stable/reference/generated/numpy.linalg.pinv.htmlPlease do have a look and let me know if should make any other change.
Thank you.