feat: add new fields regarding NULL values

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/action_model/requests/ldm_request.py

@@ -51,6 +51,7 @@ class CatalogGenerateLdmRequest(Base):
     wdf_prefix: Optional[str] = None
     pdm: Optional[CatalogPdmLdmRequest] = None
     workspace_id: Optional[str] = None
+    translation_prefix: Optional[str] = None
 
     @staticmethod
     def client_class() -> type[GenerateLdmRequest]:

packages/gooddata-sdk/src/gooddata_sdk/catalog/data_source/declarative_model/physical_model/column.py

@@ -16,6 +16,8 @@ class CatalogDeclarativeColumn(Base):
     is_primary_key: Optional[bool] = None
     referenced_table_id: Optional[str] = None
     referenced_table_column: Optional[str] = None
+    is_nullable: Optional[bool] = None
+    null_value: Optional[str] = None
 
     @staticmethod
     def client_class() -> type[DeclarativeColumn]:

packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/logical_model/dataset/dataset.py

@@ -82,6 +82,8 @@ class CatalogDeclarativeAttribute(Base):
     tags: Optional[list[str]] = None
     is_hidden: Optional[bool] = None
     locale: Optional[str] = None
+    is_nullable: Optional[bool] = None
+    null_value: Optional[str] = None
 
     @staticmethod
     def client_class() -> type[DeclarativeAttribute]:
@@ -97,6 +99,8 @@ class CatalogDeclarativeFact(Base):
     description: Optional[str] = None
     tags: Optional[list[str]] = None
     is_hidden: Optional[bool] = None
+    is_nullable: Optional[bool] = None
+    null_value: Optional[str] = None
 
     @staticmethod
     def client_class() -> type[DeclarativeFact]:
@@ -121,6 +125,8 @@ class CatalogDeclarativeAggregatedFact(Base):
     source_column_data_type: Optional[str] = None
     description: Optional[str] = None
     tags: Optional[list[str]] = None
+    is_nullable: Optional[bool] = None
+    null_value: Optional[str] = None
 
     @staticmethod
     def client_class() -> type[DeclarativeAggregatedFact]:
@@ -171,6 +177,8 @@ class CatalogDeclarativeLabel(Base):
     locale: Optional[str] = None
     translations: Optional[list[CatalogDeclarativeLabelTranslation]] = None
     geo_area_config: Optional[CatalogGeoAreaConfig] = None
+    is_nullable: Optional[bool] = None
+    null_value: Optional[str] = None
 
     @staticmethod
     def client_class() -> type[DeclarativeLabel]:
@@ -203,6 +211,8 @@ class CatalogDeclarativeReference(Base):
     source_columns: Optional[list[str]] = None
     source_column_data_types: Optional[list[str]] = None
     sources: Optional[list[CatalogDeclarativeReferenceSource]] = None
+    is_nullable: Optional[bool] = None
+    null_value: Optional[str] = None
 
     @staticmethod
     def client_class() -> type[DeclarativeReference]:

packages/gooddata-sdk/tests/catalog/expected/declarative_ldm.json

@@ -247,19 +247,12 @@
               {
                 "description": "Location",
                 "id": "geo__state__location",
-                "locale": "en-US",
                 "sourceColumn": "geo__state__location",
                 "sourceColumnDataType": "STRING",
                 "tags": [
                   "Customers"
                 ],
                 "title": "Location",
-                "translations": [
-                  {
-                    "locale": "cs-CZ",
-                    "sourceColumn": "geo__state__location_cz"
-                  }
-                ],
                 "valueType": "GEO"
               }
             ],

packages/gooddata-sdk/tests/catalog/expected/declarative_ldm_with_sql_dataset.json

@@ -40,7 +40,8 @@
             "description": "Campaign channel id",
             "tags": [
               "Campaign channels"
-            ]
+            ],
+            "isNullable": false
           },
           {
             "id": "campaign_channels.category",

packages/gooddata-sdk/tests/catalog/expected/declarative_pdm_ldm_request.json

@@ -10,7 +10,8 @@
         {
           "data_type": "STRING",
           "isPrimaryKey": true,
-          "name": "campaign_channel_id"
+          "name": "campaign_channel_id",
+          "isNullable": false
         },
         {
           "data_type": "INT",

packages/gooddata-sdk/tests/catalog/expected/declarative_workspaces_snake_case.json

@@ -261,13 +261,6 @@
                       "source_column": "geo__state__location",
                       "source_column_data_type": "STRING",
                       "description": "Location",
-                      "locale": "en-US",
-                      "translations": [
-                        {
-                          "locale": "cs-CZ",
-                          "source_column": "geo__state__location_cz"
-                        }
-                      ],
                       "tags": [
                         "Customers"
                       ],

packages/gooddata-sdk/tests/catalog/load/gooddata_layouts/default/workspaces/demo/ldm/datasets/customers.yaml

@@ -32,10 +32,6 @@ attributes:
         id: geo__state__location
         sourceColumn: geo__state__location
         sourceColumnDataType: STRING
-        locale: en-US
-        translations:
-          - locale: cs-CZ
-            sourceColumn: geo__state__location_cz
         tags:
           - Customers
         title: Location

packages/gooddata-sdk/tests/catalog/load/workspace_content/gooddata_layouts/default/workspaces/demo_testing/ldm/datasets/customers.yaml

@@ -32,10 +32,6 @@ attributes:
         id: geo__state__location
         sourceColumn: geo__state__location
         sourceColumnDataType: STRING
-        locale: en-US
-        translations:
-            - locale: cs-CZ
-              sourceColumn: geo__state__location_cz
         tags:
           - Customers
         title: Location

packages/gooddata-sdk/tests/catalog/load_with_locale/data_source_credentials/data_sources_credentials.yaml

@@ -0,0 +1,6 @@
+# (C) 2022 GoodData Corporation
+data_sources:
+  demo-test-ds: "passw0rd"
+  demo-bigquery-ds: "~/home/secrets.json"
+  demo-test-ds-databricks-client-secret: "databricks-client-secret"
+  demo-test-ds-databricks-token: "databricks-token"

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-bigquery-ds/demo-bigquery-ds.yaml

@@ -0,0 +1,11 @@
+# (C) 2022 GoodData Corporation
+id: demo-bigquery-ds
+name: demo-bigquery-ds
+schema: demo
+type: BIGQUERY
+parameters:
+    - name: "projectId"
+      value: "projectId-value-override"
+decodedParameters:
+    - name: "clientEmail"
+      value: "fake email"

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds-databricks-client-secret/demo-test-ds-databricks-client-secret.yaml

@@ -0,0 +1,19 @@
+# (C) 2024 GoodData Corporation
+id: demo-test-ds-databricks-client-secret
+name: demo-test-ds-databricks-client-secret
+permissions:
+  - assignee:
+      id: demo2
+      type: user
+    name: MANAGE
+  - assignee:
+      id: demoGroup
+      type: userGroup
+    name: USE
+schema: demo
+type: DATABRICKS
+url: jdbc:databricks://dbc-1234-abc.cloud.databricks.com:443;httpPath=/sql/1.0/warehouses/9876fdsa;
+clientId: client-id
+parameters:
+  - name: catalog
+    value: "demo"

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds-databricks-token/demo-test-ds-databricks-token.yaml

@@ -0,0 +1,18 @@
+# (C) 2024 GoodData Corporation
+id: demo-test-ds-databricks-token
+name: demo-test-ds-databricks-token
+permissions:
+  - assignee:
+      id: demo2
+      type: user
+    name: MANAGE
+  - assignee:
+      id: demoGroup
+      type: userGroup
+    name: USE
+schema: demo
+type: DATABRICKS
+url: jdbc:databricks://dbc-1234-abc.cloud.databricks.com:443;httpPath=/sql/1.0/warehouses/9876fdsa;
+parameters:
+  - name: catalog
+    value: "demo"

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds/demo-test-ds.yaml

@@ -0,0 +1,16 @@
+# (C) 2022 GoodData Corporation
+id: demo-test-ds
+name: demo-test-ds
+permissions:
+  - assignee:
+      id: demo2
+      type: user
+    name: MANAGE
+  - assignee:
+      id: demoGroup
+      type: userGroup
+    name: USE
+schema: demo
+type: POSTGRESQL
+url: jdbc:postgresql://postgres:5432/tiger?sslmode=prefer
+username: postgres

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds/pdm/campaign_channels.yaml

@@ -0,0 +1,27 @@
+# (C) 2022 GoodData Corporation
+columns:
+  - dataType: NUMERIC
+    isPrimaryKey: false
+    name: budget
+  - dataType: STRING
+    isPrimaryKey: true
+    name: campaign_channel_id
+  - dataType: INT
+    isPrimaryKey: false
+    name: campaign_id
+    referencedTableColumn: campaign_id
+    referencedTableId: campaigns
+  - dataType: STRING
+    isPrimaryKey: false
+    name: category
+  - dataType: NUMERIC
+    isPrimaryKey: false
+    name: spend
+  - dataType: STRING
+    isPrimaryKey: false
+    name: type
+id: campaign_channels
+path:
+  - demo
+  - campaign_channels
+type: TABLE

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds/pdm/campaigns.yaml

@@ -0,0 +1,13 @@
+# (C) 2022 GoodData Corporation
+columns:
+  - dataType: INT
+    isPrimaryKey: true
+    name: campaign_id
+  - dataType: STRING
+    isPrimaryKey: false
+    name: campaign_name
+id: campaigns
+path:
+  - demo
+  - campaigns
+type: TABLE

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds/pdm/customers.yaml

@@ -0,0 +1,22 @@
+# (C) 2022 GoodData Corporation
+columns:
+  - dataType: INT
+    isPrimaryKey: true
+    name: customer_id
+  - dataType: STRING
+    isPrimaryKey: false
+    name: customer_name
+  - dataType: STRING
+    isPrimaryKey: false
+    name: geo__state__location
+  - dataType: STRING
+    isPrimaryKey: false
+    name: region
+  - dataType: STRING
+    isPrimaryKey: false
+    name: state
+id: customers
+path:
+  - demo
+  - customers
+type: TABLE

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds/pdm/order_lines.yaml

@@ -0,0 +1,46 @@
+# (C) 2022 GoodData Corporation
+columns:
+  - dataType: INT
+    isPrimaryKey: false
+    name: campaign_id
+    referencedTableColumn: campaign_id
+    referencedTableId: campaigns
+  - dataType: INT
+    isPrimaryKey: false
+    name: customer_id
+    referencedTableColumn: customer_id
+    referencedTableId: customers
+  - dataType: DATE
+    isPrimaryKey: false
+    name: date
+  - dataType: STRING
+    isPrimaryKey: false
+    name: order_id
+  - dataType: STRING
+    isPrimaryKey: true
+    name: order_line_id
+  - dataType: STRING
+    isPrimaryKey: false
+    name: order_status
+  - dataType: NUMERIC
+    isPrimaryKey: false
+    name: price
+  - dataType: INT
+    isPrimaryKey: false
+    name: product_id
+    referencedTableColumn: product_id
+    referencedTableId: products
+  - dataType: NUMERIC
+    isPrimaryKey: false
+    name: quantity
+  - dataType: STRING
+    isPrimaryKey: false
+    name: wdf__region
+  - dataType: STRING
+    isPrimaryKey: false
+    name: wdf__state
+id: order_lines
+path:
+  - demo
+  - order_lines
+type: TABLE

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-test-ds/pdm/products.yaml

@@ -0,0 +1,16 @@
+# (C) 2022 GoodData Corporation
+columns:
+  - dataType: STRING
+    isPrimaryKey: false
+    name: category
+  - dataType: INT
+    isPrimaryKey: true
+    name: product_id
+  - dataType: STRING
+    isPrimaryKey: false
+    name: product_name
+id: products
+path:
+  - demo
+  - products
+type: TABLE

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-vertica-ds/demo-vertica-ds.yaml

@@ -0,0 +1,6 @@
+# (C) 2022 GoodData Corporation
+id: demo-vertica-ds
+name: demo-vertica-ds
+schema: demo
+type: VERTICA
+url: jdbc:vertica://localhost:5434/demo

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-vertica-ds/pdm/campaign_channels.yaml

@@ -0,0 +1,27 @@
+# (C) 2022 GoodData Corporation
+columns:
+- dataType: NUMERIC
+  isPrimaryKey: false
+  name: budget
+- dataType: STRING
+  isPrimaryKey: true
+  name: campaign_channel_id
+- dataType: INT
+  isPrimaryKey: false
+  name: campaign_id
+  referencedTableColumn: campaign_id
+  referencedTableId: campaigns
+- dataType: STRING
+  isPrimaryKey: false
+  name: category
+- dataType: NUMERIC
+  isPrimaryKey: false
+  name: spend
+- dataType: STRING
+  isPrimaryKey: false
+  name: type
+id: campaign_channels
+path:
+- demo
+- campaign_channels
+type: TABLE

packages/gooddata-sdk/tests/catalog/load_with_locale/gooddata_layouts/default/data_sources/demo-vertica-ds/pdm/campaigns.yaml

@@ -0,0 +1,13 @@
+# (C) 2022 GoodData Corporation
+columns:
+- dataType: INT
+  isPrimaryKey: true
+  name: campaign_id
+- dataType: STRING
+  isPrimaryKey: false
+  name: campaign_name
+id: campaigns
+path:
+- demo
+- campaigns
+type: TABLE