Draft
Conversation
…namic FederationEntity interfaces with improved configuration handling
zachmann
changed the title
Contributor
 |
|
Overall Grade Focus Area: Hygiene |
Security  Reliability  Complexity Hygiene Coverage  |
Feedback
- Mutex-bearing types being copied by value
- Several reliability smells stem from copying types that embed sync.RWMutex (and using value receivers that go unused), which duplicates locks and enables subtle races; convert those types and their methods to pointer receivers and avoid passing lock-bearing structs by value to stop the pattern.
- Accumulation of dead/leftover code
- Unused functions, parameters, and vague TODOs indicate code churn without cleanup; treating deprecated items with the proper "Deprecated: " doc comment, removing or consolidating dead code, and making TODOs actionable will prevent further bloat.
- Inconsistent style and error-handling patterns
- Redundant error checks, awkward else/if constructs, and mixed declaration styles point to missing automated style/lint enforcement; applying consistent lint rules (formatting, error-return idioms, and comment conventions) and fixing violations will eliminate these recurring small defects.
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Mar 16, 2026 12:46p.m. | Review ↗ |
| Test coverage |  |
Mar 16, 2026 12:46p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 1.6% |
35.7% [▼ down 12% from main] |
| Go | 1.6% |
35.7% [▼ down 12% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
…s; add shared rotation helpers; refactor rotation logic
…rate legacy support to dedicated helpers
…log statements for consistency
… fields and improve SQL compatibility
… public key storage operations
…rithm changes with future-dated keys
…arks and JWKS expiration
…centralized trust mark info retrieval
…-memory implementation; refactor TrustMarkIssuer to support configurable spec providers
# Conflicts: # go.mod # go.sum
…ions (SlotNumber, MaxSessions, UserType, LoginNotSupported, PoolWaitTimeout)
# Conflicts: # go.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…namic FederationEntity interfaces with improved configuration handling