This repository was archived by the owner on May 13, 2025. It is now read-only.
Allow user to set calls per minute in the RateLimiter#127
Open
ctoestreich wants to merge 2 commits intogithub:masterfrom
Open
Allow user to set calls per minute in the RateLimiter#127ctoestreich wants to merge 2 commits intogithub:masterfrom
ctoestreich wants to merge 2 commits intogithub:masterfrom
Conversation
added 2 commits
May 18, 2017 13:41
… allow faster git stuff to GHE or non-public githubs
… allow faster git stuff to GHE or non-public githubs
bguerin
approved these changes
May 18, 2017
Contributor
bguerin
left a comment
There was a problem hiding this comment.
Maybe you can avoid gratuitous formating which make the PR hard to read.
Otherwise, great !
Author
|
I tried to unwind all the tab v spaces that I would but there is no code style profile in the project and some of the formatting is a bit unclear like 1 space + 1 Tab for indents in java files. I had a hard time reproducing that format with my current style settings in IntelliJ. :) |
Contributor
|
I understand. On projects like this (without formatting settings shared), I just does not automatically format sources with my IDE. |
Author
|
@bguerin Just checking on this as we near the 1yr mark. |
Contributor
|
And ? I am not a maintainer of these plugins, I only contributed to them ... |
Author
|
Who is a maintainer? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to provide a param
callsPerMinutevia configuration block to allow more calls per minute to github. Without param default is 20. This will address some issues from #90 #17 #28 #88 @jakeswenson @alem0lars @bguerin @kevinsawickiUser can configure the following