C#: Remove splitting-awareness from Range Analysis.#21482
Merged
aschackmull merged 1 commit intogithub:mainfrom Mar 16, 2026
Merged
C#: Remove splitting-awareness from Range Analysis.#21482aschackmull merged 1 commit intogithub:mainfrom
aschackmull merged 1 commit intogithub:mainfrom
Conversation
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the last dependency on the rangeanalysis-local “splitting-awareness” reachability helper, enabling deletion of that helper library as a follow-up to #21473.
Changes:
- Replaces the
hasChildmapping that relied on a reachability configuration with a direct parent/child + CFG-node mapping. - Removes the now-unused
internal/rangeanalysis/ControlFlowReachability.qllmodule entirely.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/RangeUtils.qll |
Drops the local reachability-based child mapping and uses direct AST/Cfg-node relationships. |
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/ControlFlowReachability.qll |
Deletes the splitting-aware reachability helper module, now unused. |
You can also share your feedback on Copilot code review. Take the survey.
hvitved
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small followup for #21473 to get rid of the final use of the splitting-awareness library, so we can delete the library as well.