C++: Allow MaD barriers #21162
Open
C++: Allow MaD barriers #21162
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C++
and removed
no-change-note-required
This commit was done by Opus 4.5 with the following prompt: In the commit 004d40e I have made it so that C# CodeQL queries which use sinks defined using data extensions (also known as "models-as-data"), which are accessed using `sinkNode(Node node, string kind)`, also use barriers defined using models-as-data, which are accessed using `barrierNode(Node node, string kind)`, with the same `kind` string. Please do the same for C++. If there are any complicated cases then list them at the end for me to do manually.
owen-mc
force-pushed
the
cpp/mad-barriers
branch
from
6b6c317 to
656ebab
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables Models-as-Data (MaD) barriers for SQL injection detection in C/C++ code. The change allows SQL injection barriers to be defined using the extensible Models-as-Data framework, complementing the existing hardcoded barrier for integral types.
Changes:
- Added MaD barrier support to the SQL injection query's
isBarrierpredicate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
It seems this might also need a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit was done by Opus 4.5. I then rebased it after C++: Support models-as-data barriers and barrier guards was merged and deleted most of its work.