Replace base_state counter with a custom picklable one#129
Merged
ghandic merged 3 commits intoghandic:mainfrom Jan 14, 2026
Merged
Replace base_state counter with a custom picklable one#129ghandic merged 3 commits intoghandic:mainfrom
ghandic merged 3 commits intoghandic:mainfrom
Conversation
dc98a19 to
7a06fef
Compare
7a06fef to
1533703
Compare
Contributor
Author
|
Bump :) It would be nice to have this merge for python 3.14 compatibility! |
There was a problem hiding this comment.
Pull request overview
This pull request replaces itertools.count() with a custom _PicklableCounter class to enable pickling of JSF instances, addressing issue #128.
Changes:
- Removed
itertools.countimport and replaced it with a custom_PicklableCounterclass - The new counter class maintains the same behavior as
count(start=1), returning sequential integers starting from 1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d753800 to
d76be3b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 99.37% 99.22% -0.15%
==========================================
Files 31 31
Lines 1272 1287 +15
==========================================
+ Hits 1264 1277 +13
- Misses 8 10 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes #128