Skip to content

Replace base_state counter with a custom picklable one#129

Merged
ghandic merged 3 commits intoghandic:mainfrom
robosa:fix-itertools-no-longer-picklable-3.14
Jan 14, 2026
Merged

Replace base_state counter with a custom picklable one#129
ghandic merged 3 commits intoghandic:mainfrom
robosa:fix-itertools-no-longer-picklable-3.14

Conversation

@robosa
Copy link
Contributor

@robosa robosa commented Nov 5, 2025

FIxes #128

@robosa robosa force-pushed the fix-itertools-no-longer-picklable-3.14 branch 3 times, most recently from dc98a19 to 7a06fef Compare November 5, 2025 14:53
@robosa robosa force-pushed the fix-itertools-no-longer-picklable-3.14 branch from 7a06fef to 1533703 Compare November 5, 2025 16:03
@robosa
Copy link
Contributor Author

robosa commented Jan 12, 2026

Bump :) It would be nice to have this merge for python 3.14 compatibility!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request replaces itertools.count() with a custom _PicklableCounter class to enable pickling of JSF instances, addressing issue #128.

Changes:

  • Removed itertools.count import and replaced it with a custom _PicklableCounter class
  • The new counter class maintains the same behavior as count(start=1), returning sequential integers starting from 1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@robosa robosa force-pushed the fix-itertools-no-longer-picklable-3.14 branch from d753800 to d76be3b Compare January 13, 2026 14:08
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.22%. Comparing base (cc802a4) to head (c886525).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
jsf/parser.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   99.37%   99.22%   -0.15%     
==========================================
  Files          31       31              
  Lines        1272     1287      +15     
==========================================
+ Hits         1264     1277      +13     
- Misses          8       10       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ghandic ghandic merged commit 9b58d6f into ghandic:main Jan 14, 2026
2 of 4 checks passed
@robosa robosa deleted the fix-itertools-no-longer-picklable-3.14 branch January 15, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSF fails on Python 3.14

3 participants