common : fix SIGSEGV in _visit_pattern when quantifier follows empty seq#20470
Open
pqhaz3925 wants to merge 1 commit intoggml-org:masterfrom
Open
common : fix SIGSEGV in _visit_pattern when quantifier follows empty seq#20470pqhaz3925 wants to merge 1 commit intoggml-org:masterfrom
pqhaz3925 wants to merge 1 commit intoggml-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
llama-servercrashes with SIGSEGV when processing requests containing tool definitions with a JSON schemapatternlike:This pattern is used in MCP tool servers (e.g. Figma MCP) for
nodeIdparameters. The crash happens on the first request that includes such tools.Root Cause
In
_visit_pattern(), thetransform()lambda is called recursively when a(is encountered. When the pattern contains(?:, the parser:(, incrementsi, sees?, pushes a warning — but does not incrementipast?transform()recursively —seqis empty in the new frametransform()immediately sees?as the first characterseq.back() = ...— undefined behavior on empty vector → SIGSEGVFix
Add a guard before
seq.back()in the quantifier case:Reproduction
Any request to
/v1/chat/completionswith a tool schema containing"pattern": "^$|^(?:...)$".GDB backtrace shows:
Tested and confirmed fixed on A100 SXM4-80GB (CUDA 12.6).