llama-bench: fix case where mmap and direct-io are turned on together#20461
Open
taronaeo wants to merge 2 commits intoggml-org:masterfrom
Open
llama-bench: fix case where mmap and direct-io are turned on together#20461taronaeo wants to merge 2 commits intoggml-org:masterfrom
taronaeo wants to merge 2 commits intoggml-org:masterfrom
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #20211 (comment)
As mentioned in the thread referenced, users may inadvertently enable both
--mmapand--direct-iotogether and notice no performance difference.This PR adds additional safeguards during flag parsing to ensure that both
--mmapand--direct-iocannot have the same enabled state. Also, moved theggml_backend_load_allcall just after the flag parsing function forllama-benchto fail early if any of the flags has an error.Test Cases
--mmapis enabled by default but the user specifies--direct-io 1--mmapand--direct-ioarguments do not have the same number of values--mmapand--direct-ioare turned on together