Draft
Conversation
Collaborator
Author
|
theres a run here https://github.com/IMbackK/llama.cpp/actions/runs/22975551980/job/66703103556 to show how this works (the failure in the VGPR check is on purpose for illustration) |
CISC
reviewed
Mar 11, 2026
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Collaborator
Author
|
@CISC the hip compiler will ignore llama.cpp/ggml/src/ggml-cuda/softmax.cu Line 51 in f2ab047 |
Collaborator
|
Better split the jobs again then. |
This reverts commit efa0bfc.
Collaborator
Author
|
Right |
Collaborator
|
Check CI failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "hip-check" ci workflow, this workflow is intended to solve the following problems for us:
The idea of this workflow that its failure NOT necessarily block a pr, but that its should prompt investigation / possible adding to the workflows witelist.