Skip to content

docs(dart): Fix user attributes gated behind sendDefaultPii#16407

Merged
buenaflor merged 1 commit intomasterfrom
fix/dart-user-attributes
Feb 19, 2026
Merged

docs(dart): Fix user attributes gated behind sendDefaultPii#16407
buenaflor merged 1 commit intomasterfrom
fix/dart-user-attributes

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 17, 2026

DESCRIBE YOUR PR

Related PR: getsentry/sentry-dart#3524

This has been wrongly implemented in mobile. user attributes on logs and metrics should not be gated behind sendDefaultPii because they are manual APIs.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copilot AI review requested due to automatic review settings February 17, 2026 14:27
@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sentry-docs Ready Ready Preview, Comment Feb 17, 2026 2:34pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
develop-docs Ignored Ignored Feb 17, 2026 2:34pm

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect documentation that stated user attributes in metrics and logs are gated behind the sendDefaultPii configuration option for Dart and Apple platforms. The documentation now correctly reflects that user attributes are included when available in the current scope (via manual APIs), regardless of the sendDefaultPii setting.

Changes:

  • Updated Dart metrics documentation to indicate user attributes are included "If available" instead of "If sendDefaultPii enabled"
  • Removed misleading text from Apple metrics documentation stating user attributes require sendDefaultPii to be enabled

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
platform-includes/metrics/default-attributes/dart.mdx Updated user attributes condition from "If sendDefaultPii enabled" to "If available" in the metrics attributes table
platform-includes/metrics/default-attributes/apple.mdx Removed incorrect statement that user attributes are only added when sendDefaultPii is enabled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@buenaflor buenaflor merged commit 86b5850 into master Feb 19, 2026
21 checks passed
@buenaflor buenaflor deleted the fix/dart-user-attributes branch February 19, 2026 10:14
codyde added a commit that referenced this pull request Feb 19, 2026
* origin/master:
  docs(sdk): coordination and maintenance standards (#16463)
  docs(sdk): add spec format components and migrate check-ins (#16461)
  docs(sdk): repository and documentation standards (#16462)
  docs(sdk): Add issue saved replies and simplify CopyableCard (#16459)
  docs(sdk): add review & ci standard (#16458)
  fix(unity): correct lifecycle breadcrumbs docs (#16456)
  docs(sdk): add code quality standard (#16455)
  docs(sdk): migrate releases process to playbook and standard (#16447)
  docs(sdk): merge basics.mdx into overview.mdx (#16446)
  docs(sdk): remove old triaging process page (#16448)
  docs(dart): Update stacktrace info for the logging integration (#16401)
  docs(dart): Fix user attributes gated behind `sendDefaultPii` (#16407)
  feat(playstation): Add symbols documentation for dumps (#16454)
  feat(develop-docs): Restore Sentry Voice guidelines page (#16453)

# Conflicts:
#	app/[[...path]]/page.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments