This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Allow extra to be None in breadcrumbs processing#1309
Open
joker-at-work wants to merge 1 commit intogetsentry:masterfrom
Open
Allow extra to be None in breadcrumbs processing#1309joker-at-work wants to merge 1 commit intogetsentry:masterfrom
extra to be None in breadcrumbs processing#1309joker-at-work wants to merge 1 commit intogetsentry:masterfrom
Conversation
Sometimes, `extra` is passed in as a default parameter of another function and can therefore be `None`. This fixes: Traceback (most recent call last): File "raven/breadcrumbs.py", line 77, in get_buffer processor(payload) File "raven/breadcrumbs.py", line 143, in processor data_value.update(extra) TypeError: 'NoneType' object is not iterable
|
The issue addressed by this PR is preventing my team from upgrading to 6.10.0. The issue in my particular project arises when calling |
Contributor
|
@david-volantio if you are able to upgrade, any reason for not being able to give the new sdk a go? https://github.com/getsentry/sentry-python |
|
@ashwoods a fair point - I was just hoping we could move to the latest release but updating to sentry-python is definitely on our roadmap. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes,
extrais passed in as a default parameter of anotherfunction and can therefore be
None. This fixes: