fix misleading localhost comment for proxy_1 service URL#37
Open
erenyegit wants to merge 1 commit intogetoptimum:mainfrom
Open
fix misleading localhost comment for proxy_1 service URL#37erenyegit wants to merge 1 commit intogetoptimum:mainfrom
erenyegit wants to merge 1 commit intogetoptimum:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Optimum Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughUpdated development-mode example URLs in the getting-started CLI guide from localhost proxy endpoint (port 8081) to docker network endpoint (port 8080), with corresponding commentary adjustments reflecting the network context change. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
proxy_1aslocalhostin the CLI getting-started guide.Why this matters
proxy_1is a Docker service hostname and is not reachable vialocalhost.Scope
Summary by CodeRabbit