Use PGPASSWORD env var for postgres test credentials #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test_helpers.hpp with make_credentials() that checks for PGPASSWORD environment variable, falling back to "password" if not set. This allows running tests against an existing postgres instance. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Note: I've added this PR because I already have a Postgres instance running on my machine and I rather run the tests against it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test_helpers.hppwithmake_credentials()utility functionPGPASSWORDenv var, falls back to"password"if not setThis allows running tests against an existing postgres instance without requiring password to be
"password".Test plan
test_aggregationspassestest_listen_notifytests pass (file with 5 credential usages)🤖 Generated with Claude Code