Skip to content

Comments

fix: wait for the window to match full screen size#254

Merged
iparaskev merged 3 commits intomainfrom
fix_crash
Feb 5, 2026
Merged

fix: wait for the window to match full screen size#254
iparaskev merged 3 commits intomainfrom
fix_crash

Conversation

@iparaskev
Copy link
Contributor

@iparaskev iparaskev commented Feb 5, 2026

On windows it could take longer for the overlay window to become full screen and as a result the surface could be created with the smaller than full screen dimensions.

Summary by CodeRabbit

  • Bug Fixes

    • Improved fullscreen reliability: borderless fullscreen now better matches the monitor, waits briefly (up to a short timeout) for the window to reach the expected size, and reports a failure if the size never matches.
    • Enhanced cross-platform error handling for fullscreen transitions so failures are surfaced promptly.
  • Chores

    • Added extra diagnostic logging showing window size and scale during graphics initialization.

On windows it could take longer for the overlay window to become
full screen and as a result the surface could be created with the
smaller than full screen dimensions.
@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 5d87077
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/698465667eae7600083ed3b3
😎 Deploy Preview https://deploy-preview-254--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding a wait mechanism for the window to match fullscreen size, which is the core fix described in the PR objectives and reflected in the code changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_crash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@core/src/window_manager.rs`:
- Around line 355-367: The log messages inside set_fullscreen currently use the
wrong function name prefix "create_overlay_window:"; update the two log::info!
and log::error! calls in set_fullscreen to use the correct prefix
"set_fullscreen:" (or an equivalent accurate identifier) so the logs match the
function name and avoid the copy-paste artifact.

@iparaskev iparaskev merged commit 970c223 into main Feb 5, 2026
6 of 8 checks passed
@iparaskev iparaskev deleted the fix_crash branch February 5, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant