[WIP] Make sure that the compositional fields are mapped to the correct particle properties#6871
Open
YiminJin wants to merge 3 commits intogeodynamics:mainfrom
Open
[WIP] Make sure that the compositional fields are mapped to the correct particle properties#6871YiminJin wants to merge 3 commits intogeodynamics:mainfrom
YiminJin wants to merge 3 commits intogeodynamics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to address the problems shown in #6863 . It forces
mapped_particle_propertiesto be created, and let the particle property plugins check if the compositional fields are mapped to the correct particle properties. Further, it makesParticle::Property::InitialCompositiononly declare particle properties prefixed byinitial, so the duplication is removed.However, there are two problematic particle property plugins
compositionandcomposition reaction, which set the property names identical to the corresponding compositional field names, so I cannot sort out the fields that ought to be mapped to these properties. A potential solution is to declare parameters for these plugins to specify the compositional fields to be mapped. Another solution is to treat the two plugins as special ones and let the property manager decide the properties to be mapped to them. Which solution is better? And are there better solutions?