[WIP, request for feedback] Update gwb to version 1.1#6866
Open
MFraters wants to merge 2 commits intogeodynamics:mainfrom
Open
[WIP, request for feedback] Update gwb to version 1.1#6866MFraters wants to merge 2 commits intogeodynamics:mainfrom
MFraters wants to merge 2 commits intogeodynamics:mainfrom
Conversation
MFraters
force-pushed
the
update_gwb_to_v1.1
branch
from
8b1631a to
0e99da1
Compare
gassmoeller
reviewed
Mar 13, 2026
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
I dont think I will be able to read the 40000 lines of code changed ;-). But what I can say: I tested this branch on my system and it works (even with some experimental changes I am making at the moment to ASPECT and deal.II). The testers also seem to pass without having to update any test output.
So I think in general there is no obstacle to the WB release and then including that in the next ASPECT release.
Is there anything specific you would like us to look at?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The world builder is I think ready for another release (it has been a while, there have been quite a few changes, a new world builder hack is coming up and a new aspect release is coming up), so as usual, I am making a pull request to aspect to check if everything works as expected and to get feedback if any changes need to be made for including into aspect.
Note 1: I will later manually return the
cmake_minimum_required(VERSION 3.13.4)line.Note 2: The status of the release process can be found here: GeodynamicWorldBuilder/WorldBuilder#863.