Open
Conversation
Contributor
|
I would suggest removing the MHD test for now while we work on building something with a non-random initial condition. I just ran the hydro test on my machine and it's good. Also, I did a quick sanity check to make sure that significant changes in the measured variables were occurring after such a short number of timesteps, and they are, so I think the hydro test is great. I can approve and merge asap once the MHD test is removed (assuming you haven't already come up with a fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #557 by adding the j2011 test cases to the test suite. Let's see how the testers react.