Update conditional argument handling to correctly support lambdas#246
Merged
geekq merged 1 commit intogeekq:developfrom Oct 16, 2025
Merged
Update conditional argument handling to correctly support lambdas#246geekq merged 1 commit intogeekq:developfrom
geekq merged 1 commit intogeekq:developfrom
Conversation
Contributor
Author
|
@geekq review please :) I also have another PR incoming for the condition kwarg issue I tagged you in yesterday |
Contributor
Author
|
Ping |
Owner
|
Merged this PR first. The #247 will require a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the event
conditioncall to check arity even when not using methods, since the user may have defined a condition using a lambda instead of a block. ie.Without this PR's change, this example raises an ArgumentError if you do something like
obj.exit!(123), because the lambda is being called with 2 arguments when it expects 1.Explanation
There are two types of Procs in Ruby, lambda-based procs and non-lambda (block-like) procs. They enforce arguments differently:
Block like
Lambda/stabby arrow
Thus we should check arity when calling an event's condition method or block/proc/lambda.