Allow user to specify a bigger output buffer#25
Open
joemcool wants to merge 2 commits intogeekfactory:masterfrom
Open
Allow user to specify a bigger output buffer#25joemcool wants to merge 2 commits intogeekfactory:masterfrom
joemcool wants to merge 2 commits intogeekfactory:masterfrom
Conversation
This PR creates a macro CONFIG_SHELL_OUT_BUFFER_LEN which defines the length of the output buffer. This should be large enough to accommodate most large writes via the shell_print functions, but still small enough to fit in a single shell_bwriter call (ie, for Telnet, smaller than the TCP Maximum Transmission Unit, 1500 bytes). This buffer is also statically allocated, and should not be so large that it uses all the available RAM in the system. The macro is set to the original output buffer size (30 bytes).
Owner
|
Thank you for submitting your pull requests. I'll review them soon and try to release an updated version of the library soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a macro
CONFIG_SHELL_OUT_BUFFER_LENwhich defines the length of the output buffer. This should be large enough to accommodate most large writes via theshell_printfunctions, but still small enough to fit in a singleshell_bwritercall (ie, UINT_8T_MAX, 255 bytes). This buffer is also statically allocated, and should not be so large that it uses all the available RAM in the system. The macro is set to the original output buffer size (30 bytes).