Fixed issue #16 so that shell_print_commands() no longer crashes#17
Open
joemcool wants to merge 1 commit intogeekfactory:masterfrom
Open
Fixed issue #16 so that shell_print_commands() no longer crashes#17joemcool wants to merge 1 commit intogeekfactory:masterfrom
joemcool wants to merge 1 commit intogeekfactory:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #16, shell_print_commands() crashes. This PR adds an
#ifdef ARDUINOwrapper to theshell_print_commands()function's loop so that the correct print_ln function gets called.The PR also adds an example showing the usage of
shell_print_commands()that I used for testing. The example is a copy of Shell_Basic with an extra "help" command added. The example also has a description in English and my own barely passable Spanish ;)