Fix stopping of old test cluster when pg_ctl is not in the path #692
+20
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the pg_ctl binary was not in the path we would fail to stop the running database clusters so let's use our helper for getting the path to the binary. To keep the code simple we also move the stopping of the existing cluster to the code which starts it since that is only where we, at least currently, knows the path the the binaries.
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
pg_ctlbinary was not in the path we would fail to stop the running database clusters so let's use our helper for getting the path to the binary.To keep the code simple we also move the stopping of the existing cluster to the code which starts it since that is only where we, at least currently, knows the path the the binaries.