-
Notifications
You must be signed in to change notification settings - Fork 5
feat: support override methods in services #1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @m62624, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement by enabling method overriding in services, providing a powerful mechanism for customizing inherited behavior. It integrates a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new feature: the ability to override methods in services. The changes span across the macro implementations, client code generation, and example applications to demonstrate the functionality. The core logic for handling overrides in the gservice macro seems well-thought-out. I've identified a few areas for improvement, including an inefficiency in the new example code, a potential bug in the client code generation, a logic issue in the new override_entry attribute macro, and a small redundancy in the macro implementation. Addressing these points will help ensure the robustness and maintainability of this new feature.
3c4f49b to
8bb4f83
Compare
- feat: add find_method_data - refactor: generate_fn_hash - fix: tests - fix: check_asyncness_impl
8bb4f83 to
1a0a014
Compare
rs/macros/core/tests/snapshots/gservice__works_with_overrides.snap
Outdated
Show resolved
Hide resolved
rs/macros/core/tests/snapshots/gservice__works_with_overrides.snap
Outdated
Show resolved
Hide resolved
rs/macros/core/tests/snapshots/gservice__works_with_overrides.snap
Outdated
Show resolved
Hide resolved
c5a7a2f to
847df89
Compare
d967979 to
120eecc
Compare
🔬 Benchmark Comparison
Legend
🤖 This comment was automatically generated by the benchmark comparison workflow at 116aece. |
Resolves #1179