-
Notifications
You must be signed in to change notification settings - Fork 3
Test for simulated events in integration tests calling sim_telarray #2035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
GernotMaier
wants to merge
51
commits into
flasher-sims
Choose a base branch
from
sim_telarray_file_tests
base: flasher-sims
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Close figures in unit tests for plot_simtel_events.
Reduce debug messages; avoid printing DB passwords in log output
Remove mrra optimization here
Add checks for simulation software executable paths and existence of corsika interaction paths.
New flasher test file
Pre-commit update for codespell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized recently that some integration tests to not generate any events (e.g. #2028, #2029).
Add functionality to test output of sim_telarray files after running the integration tests. Add possibility to require either telescope or calibration events.
Update all integration tests calling sim_telarray files.
This likely will require a few fixes in simtools before all integration tests pass.