Remove mrra optimization here #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GernotMaier
approved these changes
Feb 10, 2026
| ), | ||
| type=float, | ||
| default=0.01, | ||
| default=0.0001, |
Contributor
There was a problem hiding this comment.
This is an unusual small learning rate, or? Just a comment, no need to change.
Collaborator
Author
There was a problem hiding this comment.
It is small, but after removing rnda from this function the larger learning rate was too large. The learning rate is adaptive anyway so it's not going to stay the same, this is just the starting rate for the first step.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization has been moved to
derive_mirror_rnda, and somirror_reflection_random_angleis being removed as a parameter in this optimization.