feat: Add support for dialog tag and create example templates#331
Open
0yeifer wants to merge 4 commits intofrappe:developfrom
Open
feat: Add support for dialog tag and create example templates#3310yeifer wants to merge 4 commits intofrappe:developfrom
dialog tag and create example templates#3310yeifer wants to merge 4 commits intofrappe:developfrom
Conversation
…s` instead of remove display from base styles in `Block` class frappe#330
dialog tag and create example templates #330dialog tag and create example templates
Author
|
Hello @surajshetty3416 Is there any issue with this PR or something that needs to be changed/improved? I could work on any corrections if needed. |
Member
|
@0yeifer if you are still around, can you try and make this feature completely functional using this feature (it's almost at the final stage of review) by adding block level scripts? |
Author
|
Hi @surajshetty3416 , sure, I'll check it out 👀 |
Member
|
@0yeifer, the feature is merged now... if you want to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Dialog Block Templates Added
Two native
<dialog>templates are now available:onclick="<dialogId>.showModal()"Validate and Close(form submission viamethod="dialog"validating input required)Non-Validate Close(submit without validation using attributeformnovalidate)JS Close(native call toclose()method viaonclick="<dialogId>.close()")Esckey cancellationopenattribute) with confirmation buttonKey Implementation Notes:
HTMLDialogElementmethods via ID referencesNext Steps:
There is an editor/published view visibility discrepancy that remains unresolved due to the display handling.
Awaiting feedback, I will keep an eye on the PR for any necessary changes.