Replace \ with / in file names when packing#573
Open
madebyisaacr wants to merge 3 commits intomainfrom
Open
Conversation
niekert
reviewed
Mar 2, 2026
packages/plugin-tools/src/lib.ts
Outdated
| zip.addFile(markerFileName, Buffer.from("true", "utf-8")) | ||
|
|
||
| // Normalize all entry paths to use forward slashes | ||
| for (const entry of zip.getEntries()) { |
Member
There was a problem hiding this comment.
Lets add a test for this in lib.test.ts
Member
I'm not sure I understand. Do you name it |
Collaborator
Author
Name it assets\hero in the file name. Windows uses \ instead of / for file directories and usually it handles converting to / when packing automatically, but apparently not always. Keep the forward slash in the import. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates framer-plugin-tools to replace \ with / in file names.
This plugin's CSS file has the name:
assets\index-DA6fbhnP.cssWhich gets mapped to this when URL encoded:
assets%5Cindex-DA6fbhnP.css(link)But the stylesheet in the index.html file references
/assets/index-DA6fbhnP.cssso the file doesn't load.I have never seen this before today, so it's probably an unusual quirk of using Windows and having an abnormal build config or something like that.
Testing
The way I tested on macOS is by opening the google-sheets plugin, moving the src/assets/hero.png file to the src/ folder and renaming it to "assets\hero.png" to simulate using a \ for directories like on Windows.