Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
brookfxg
force-pushed
the
brook/dc-519-add-python-client-support
branch
from
e31044b to
6d354d9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
brookfxg
force-pushed
the
brook/dc-519-add-python-client-support
branch
from
6d354d9 to
b0a1450
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
brookfxg
force-pushed
the
brook/dc-519-add-python-client-support
branch
from
b0a1450 to
b994e10
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
brookfxg
force-pushed
the
brook/dc-519-add-python-client-support
branch
from
b994e10 to
35666c5
Compare
There was a problem hiding this comment.
All prior feedback addressed — sort_by docs, id shadowing, test query param assertions, docstring style, double-space, and URL encoding (urlquote) are all cleaned up. test_get_session_by_key covers the key-based lookup path. Nice work iterating on this.
Code follows existing codebase patterns (get_events, _event_dict, etc.) well. The urlquote(identifier, safe="") correctly handles URL-special characters in session keys.
Public API surface addition on a published PyPI package — deferring to a human for final sign-off.
2 participants
Changelog
Adds support for Sessions operations.
Docs
Public API docs will be separately updated at time of release.
Description
Important: Hold merge until GA release
Adds support for Sessions operations.