Skip to content

Add project id as an optional param to create event#142

Merged
dakota-foxglove merged 4 commits intomainfrom
hebert/project-id-optional
Feb 24, 2026
Merged

Add project id as an optional param to create event#142
dakota-foxglove merged 4 commits intomainfrom
hebert/project-id-optional

Conversation

@dakota-foxglove
Copy link
Contributor

@dakota-foxglove dakota-foxglove commented Feb 19, 2026

Changelog

Adds project_id as an optional param to create_event to disambiguate between devices with the same name in different projects.

Description

Adds project id as an optional param to create event using the python api

Copy link
Member

@mguida22 mguida22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want a changelog entry for this

dakota-foxglove and others added 2 commits February 19, 2026 14:20
Co-authored-by: Mike Guida <guida@foxglove.dev>
Copy link
Member

@mguida22 mguida22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this depends on pending API changes https://github.com/foxglove/app/pull/12627

@mguida22 mguida22 requested a review from brookfxg February 23, 2026 20:22
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, focused change. Implementation follows the existing patterns for project_id used elsewhere in the client (e.g., get_events, get_devices, create_device). The None-filtering via the dict comprehension handles the optional parameter correctly, and the test covers the device_name + project_id combination well.

No blockers from me. Submitting as COMMENT rather than APPROVE since this adds a new parameter to a public API surface on a public package — should have a human sign-off.

@dakota-foxglove
Copy link
Contributor Author

Testing these python changes

created_event = client.create_event(
    device_name="dakota-test",
    # project_id=PROJECT_ID,
    start=start,
    end=start,
    metadata={"note": "created from local_notebook.ipynb", "device_name": DEVICE_NAME},
)
image

Uncommented project_id:
image

@dakota-foxglove dakota-foxglove merged commit 99cfbe0 into main Feb 24, 2026
5 checks passed
@dakota-foxglove dakota-foxglove deleted the hebert/project-id-optional branch February 24, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants