Add project id as an optional param to create event#142
Merged
dakota-foxglove merged 4 commits intomainfrom Feb 24, 2026
Merged
Add project id as an optional param to create event#142dakota-foxglove merged 4 commits intomainfrom
dakota-foxglove merged 4 commits intomainfrom
Conversation
mguida22
approved these changes
Feb 19, 2026
Member
mguida22
left a comment
There was a problem hiding this comment.
We'll want a changelog entry for this
Co-authored-by: Mike Guida <guida@foxglove.dev>
mguida22
requested changes
Feb 19, 2026
Member
There was a problem hiding this comment.
this depends on pending API changes https://github.com/foxglove/app/pull/12627
There was a problem hiding this comment.
Clean, focused change. Implementation follows the existing patterns for project_id used elsewhere in the client (e.g., get_events, get_devices, create_device). The None-filtering via the dict comprehension handles the optional parameter correctly, and the test covers the device_name + project_id combination well.
No blockers from me. Submitting as COMMENT rather than APPROVE since this adds a new parameter to a public API surface on a public package — should have a human sign-off.
Contributor
Author
mguida22
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Changelog
Adds
project_idas an optional param tocreate_eventto disambiguate between devices with the same name in different projects.Description
Adds project id as an optional param to create event using the python api