page inline partials to be used within layout#285
Open
jaket-hub wants to merge 4 commits intofoundation:developfrom
Open
page inline partials to be used within layout#285jaket-hub wants to merge 4 commits intofoundation:developfrom
jaket-hub wants to merge 4 commits intofoundation:developfrom
Conversation
…within layout pages
modify render
- only pages with inline partials
- check for online partial(s) starting with "layout-", add them to Handlebars.partials
- remove inline partial(s) text/string from page.body
- all pages
- check for Handlebars.partials starting with "layout-" and remove them
modify test
- add in test files and modify test script
https://regex101.com/r/RF1IOl/1 - for matching handlebars comment include numbers match in inline partials name https://regex101.com/r/qFKeWd/2 for matching handlebars inline partial handlebars comment removed from string for inline partial match Test - added top and bottom partials above and below body respectively - added test pages for inline partials top, bottom and commented inline partials
filter out comment and only use partial matches https://regex101.com/r/qPmiU8/2 https://www.rexegg.com/regex-best-trick.php#thetrick
add options.inlinelayout to readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page inline partials with prefix
'layout-'
or options.inlinelayout
or Front Matter inlinelayout
can be used within layout