Skip to content

Comments

Absolute Path for Options#169

Open
mou01 wants to merge 2 commits intofoundation:masterfrom
mou01:master
Open

Absolute Path for Options#169
mou01 wants to merge 2 commits intofoundation:masterfrom
mou01:master

Conversation

@mou01
Copy link

@mou01 mou01 commented May 3, 2018

Fixes #164

@marvinhuebner
Copy link

marvinhuebner commented Nov 6, 2018

I've a similar situation there i have to check if the path is absolute. My solution has looked like this:

for (var i in dir) {
  var cwd = '';

  if (!path.isAbsolute(dir[i])) {
    cwd = process.cwd();
  }

  files = files.concat(glob.sync(path.join(cwd, dir[i], pattern)));
}

But i think your code does it fix it in a smarter way.

@gakimball is there a way to get this into?

@DanielRuf
Copy link
Contributor

In another repo we had the same. Someone recommended path.resolve there.

See foundation/style-sherpa#5 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants