Change health check url for kb service

[soimkim]

Description

• Chores
  • Improved KB server health check: uses a more robust reachability probe, longer timeout, and richer error logging for easier troubleshooting.
  • Updated KB server endpoint configuration to centralize and simplify how the service URL is constructed, improving maintainability and reducing risk of misconfiguration.

[coderabbitai]

Warning

Rate limit exceeded

@soimkim has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 36f3920b-344f-4a84-b26b-b9f2957eaedc

📥 Commits

Reviewing files that changed from the base of the PR and between 4fae1f9 and 7468ecb.

📒 Files selected for processing (1)

• src/fosslight_source/cli.py

📝 Walkthrough

Walkthrough

KB interaction updated: KB_URL changed from a full endpoint to a base domain, and the health check now performs a GET to KB_URL + "health" with expanded error logging for HTTP, URL, and unexpected exceptions.

Changes

Cohort / File(s)	Summary
KB Server config & health check src/fosslight_source/_scan_item.py, src/fosslight_source/cli.py	KB_URL shortened to base domain (http://fosslight-kb.lge.com/). Health-check logic changed to GET KB_URL + "health" with increased timeout and richer error logging (HTTPError, URLError, general exceptions). Imports for urllib.parse, json, and socket added in cli.py.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: modifying how the health check URL is constructed for the KB service by separating the base URL from the endpoint.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch health

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/fosslight_source/cli.py`:
- Around line 13-15: Remove the unused imports at the top of the module: delete
the import statements for urllib.parse, json, and socket from the top-level
import block (the lines introducing urllib.parse, json, socket in cli.py);
confirm no references to these symbols remain and run the linter/pytest to
ensure nothing else relies on them.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 32f0705c-db61-48c7-a44b-bd3b25d57726

📥 Commits

Reviewing files that changed from the base of the PR and between 4b4c82b and 8d7a919.

📒 Files selected for processing (2)

• src/fosslight_source/_scan_item.py
• src/fosslight_source/cli.py

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

src/fosslight_source/cli.py (1)

13-15: ⚠️ Potential issue | 🟡 Minor

Remove the unused imports.

urllib.parse, json, and socket are still not referenced anywhere in this module.

♻️ Proposed fix

 import urllib.request
 import urllib.error
-import urllib.parse
-import json
-import socket
 from datetime import datetime

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/fosslight_source/cli.py` around lines 13 - 15, The file imports
urllib.parse, json, and socket at the top of src/fosslight_source/cli.py but
those symbols are unused; remove the three import statements (the identifiers
urllib.parse, json, socket) from the module import block in cli.py and run a
quick lint/test to confirm nothing else in the file relies on them before
committing.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/fosslight_source/cli.py`:
- Around line 269-275: The health-check currently treats any non-404 HTTPError
as healthy; update the logic around
urllib.request.Request/urllib.request.urlopen so that only successful 2xx
responses (check response.status in the 200-299 range) return True, and all
HTTPError paths (except improbable 2xx) return False; adjust the except
urllib.error.HTTPError as e branch to log e.code via logger.debug and return
False (do not treat 401/403/500/503 as healthy).

---

Duplicate comments:
In `@src/fosslight_source/cli.py`:
- Around line 13-15: The file imports urllib.parse, json, and socket at the top
of src/fosslight_source/cli.py but those symbols are unused; remove the three
import statements (the identifiers urllib.parse, json, socket) from the module
import block in cli.py and run a quick lint/test to confirm nothing else in the
file relies on them before committing.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e46e4455-6513-46b3-92fc-836f70557acc

📥 Commits

Reviewing files that changed from the base of the PR and between 8d7a919 and 4fae1f9.

📒 Files selected for processing (1)

• src/fosslight_source/cli.py