This repository was archived by the owner on Mar 3, 2019. It is now read-only.
Initial setup of filterbox on popover.#10
Open
derivagral wants to merge 1 commit intoforkdelta:masterfrom
Open
Initial setup of filterbox on popover.#10derivagral wants to merge 1 commit intoforkdelta:masterfrom
derivagral wants to merge 1 commit intoforkdelta:masterfrom
Conversation
Did PairFilterBox pretty quick, open to refactors. Styling's very basic; good-enough?
freeatnet
previously requested changes
Jan 18, 2018
| constructor(props) { | ||
| super(props); | ||
| this.state = {filterText: ''}; | ||
| this.onStateChange = this.onStateChange.bind(this); |
Contributor
There was a problem hiding this comment.
Consider using funcName = () => {} at class level?
Contributor
|
I think we're on the right track UI-wise. I've thrown a bit of styling overtop the component, seen above. Does it look right to you? Styling as seen:
|
Contributor
Author
|
I can move the filterstate into redux, sure. Initially I wasn't sure that it'd need the wider scope, but being able to share the filter/selection from the popover box to any other select dialog would be kind of nice. I should get some time for that tomorrow afternoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did PairFilterBox pretty quick, open to refactors.
Styling's very basic; good-enough?