Merged
Conversation
Korijn
commented
Dec 14, 2025
Collaborator
|
Since you've added some extra benchmarks, it might make sense to use the same benchmarking strategy that I applied at observ where it runs the new benchmarks also on the code from master. |
Collaborator
Author
How's this? |
Collaborator
Author
|
Other changes led to marginal improvements. |
berendkleinhaneveld
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #7
Changes:
Since patchdiff is typically used as a low level tool in hot codepaths, this kind of micro-optimization is worthwhile.