fix warnings when values set in .json file: minUptime and spinSleepTime#819
Open
skimj wants to merge 1 commit intoforeversd:masterfrom
skimj:patch-1
Open
fix warnings when values set in .json file: minUptime and spinSleepTime#819skimj wants to merge 1 commit intoforeversd:masterfrom skimj:patch-1
skimj wants to merge 1 commit intoforeversd:masterfrom
skimj:patch-1
Conversation
Warnings are thrown during getOptions if minUptime and/or spinSleepTime are not set as CLI arguments. If these parameters are defined in a .json config file, the program flow first checks for the CLI argument, throws the warning and then sets the options based on the .json parameters. This is a simple fix to the if statement which also checks if these parameters are set in the .json file.
kibertoad
reviewed
Jan 5, 2019
| : [options.watchIgnore]; | ||
|
|
||
| if (!options.minUptime) { | ||
| if (!options.minUptime && ~configs.indexOf("minUptime")) { |
Contributor
There was a problem hiding this comment.
What does ~ before configs mean in this context? Did you mean !?
kibertoad
requested changes
Jan 5, 2019
Contributor
kibertoad
left a comment
kibertoad
left a comment
There was a problem hiding this comment.
Please review the pointed out part of the PR
shwq774791378
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warnings are thrown during getOptions if minUptime and/or spinSleepTime are not set as CLI arguments. If these parameters are defined in a .json config file, the program flow first checks for the CLI argument, throws the warning and then sets the options based on the .json parameters. This is a simple fix to the if statement which also checks if these parameters are set in the .json file.