Skip to content

fix: ci build failures php containers #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ma-04 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

fix: ci build failures php containers #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
981e79e
fix: fix build failure related to composer git clone using ssh
ma-04 Jan 20, 2026
ca8bc07
fix: Use git repo instead of package name
ma-04 Jan 21, 2026
7a86e7a
fix: build failure
ma-04 Jan 22, 2026
9d434c8
chore: update to latest build-push-action@v6
ma-04 Jan 22, 2026
3895a65
chore: update actions version and add continue-on-error
ma-04 Jan 22, 2026
ab6f96b
Merge branch 'flywp:main' into fix/build_failures
ma-04 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ env:

jobs:
build-php:
continue-on-error: true
Copy link

@coderabbitai coderabbitai bot Jan 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

continue-on-error: true should be temporary.

This allows broken PHP version builds to be silently ignored in production deployments. While useful for debugging which versions fail, leaving this permanently risks pushing incomplete image sets. Consider adding a TODO comment or tracking issue to remove this once the root cause is fixed.

🤖 Prompt for AI Agents 
In @.github/workflows/deploy.yml at line 22, The workflow currently sets
continue-on-error: true which should only be temporary; change the key
(continue-on-error) back to false (or remove it) so failed PHP-version jobs will
fail the deployment, and add a TODO comment referencing a tracking issue or
ticket ID to remove the temporary allowance once the root cause is fixed; update
the deploy.yml entry that defines continue-on-error to reflect this and include
the TODO/issue reference in the comment.

Copy link
Member Author

@ma-04 ma-04 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be resolved while merging. Currently there for debugging

Copy link

@coderabbitai coderabbitai bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ma-04, thanks for the clarification! That makes perfect sense for debugging purposes. I appreciate you planning to address this before merging. If you'd like, adding a TODO comment in the workflow file itself could serve as a helpful reminder during the merge process.

Looking forward to seeing the final fix!

runs-on: ubuntu-latest
strategy:
#fail-fast: false
matrix:
php_version: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Build PHP Docker image
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
with:
file: php/Dockerfile
context: php
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
uses: docker/setup-buildx-action@v3

- name: Build OpenLiteSpeed Docker image
uses: docker/build-push-action@v5
uses: docker/build-push-action@v6
with:
file: openlitespeed/Dockerfile
context: openlitespeed
Expand Down
5 changes: 3 additions & 2 deletions php/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ RUN apk add --no-cache curl \

# Stage for WP-CLI
FROM php:${PHP_VERSION}-cli-alpine AS wpcli_builder
RUN apk add --no-cache curl \

RUN apk add --no-cache curl git \
&& curl -O https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar \
&& chmod +x wp-cli.phar \
&& mv wp-cli.phar /usr/local/bin/wp \
&& wp package install wp-cli/doctor-command:@stable --allow-root \
&& mkdir -p /home/www-data/.wp-cli \
&& wp --allow-root package install https://github.com/wp-cli/doctor-command.git \
&& mv ~/.wp-cli/packages /home/www-data/.wp-cli/ \
&& chown -R www-data:www-data /home/www-data/.wp-cli \
&& rm -rf /var/cache/apk/*
Expand Down
Loading