-
Notifications
You must be signed in to change notification settings - Fork 2
chore: update canary-checker source references #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| For all mdx/md files in @docs/canary-checker/ and @docs/mission-control/ that have `<!-- Source: ... -->` comments pointing to Go source files: | ||
|
|
||
| 1. Update the Source comments to use `#StructName` format without line numbers (e.g., `checks.go#HTTPCheck` not `checks.go:117#HTTPCheck`) | ||
|
|
||
| 2. For each documented struct, compare ALL public fields from the Go source against the documentation and: | ||
| - Add any missing fields | ||
| - Fix incorrect field names (check json/yaml tags - use the json/yaml tag name, not the Go field name) | ||
| - If json/yaml tag differ from each other, warn user | ||
| - Fix incorrect schemes/types (e.g., `Duration` vs `int`, `bool` vs `string`) | ||
| - Fix incorrect nested structures (check if fields are inline or nested under a parent key) | ||
| - Remove fields that don't exist in the Go struct | ||
| - For inline embedded structs, verify which fields they provide | ||
|
|
||
| 3. For \_canary-spec.mdx, ensure all check types from CanarySpec are listed with correct field names matching the json/yaml tags | ||
|
|
||
| Pay attention to: | ||
|
|
||
| - yaml tags like `yaml:"env"` mean the field name in docs should be `env`, not the Go field name | ||
| - Inline embedded structs (e.g., `Connection`, `Description`, `Templatable`) - their fields appear at the same level | ||
| - Pointer vs value types for nested structs | ||
| - Deprecated fields should be marked as such | ||
| - ignore private fields | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -7,7 +7,7 @@ sidebar_custom_props: | |||||||||
|
|
||||||||||
| # <Icon name="git" /> Git | ||||||||||
|
|
||||||||||
| <!-- Source: modules/canary-checker/api/v1/checks.go:829#GitProtocolCheck --> | ||||||||||
| <!-- Source: modules/canary-checker/api/v1/checks.go#GitHubCheck --> | ||||||||||
|
|
||||||||||
| <Standard /> | ||||||||||
|
|
||||||||||
|
|
@@ -17,6 +17,7 @@ Execute as SQL style query against a github repo using [mergestat-lite](https:// | |||||||||
| ``` | ||||||||||
|
|
||||||||||
| <HealthCheck name="github" rows={[ | ||||||||||
| {field: "githubToken", description: "Github Personal Access Token", scheme: 'EnvVar', required: true}, | ||||||||||
| {field: "connection", description: "Connection name for GitHub credentials", scheme: 'string'}, | ||||||||||
| {field: "githubToken", description: "Github Personal Access Token", scheme: 'EnvVar'}, | ||||||||||
|
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Capitalize “GitHub” consistently in the token description. Minor doc polish to match the official product name. 🔧 Suggested edit- {field: "githubToken", description: "Github Personal Access Token", scheme: 'EnvVar'},
+ {field: "githubToken", description: "GitHub Personal Access Token", scheme: 'EnvVar'},📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[uncategorized] ~21-~21: The official name of this software platform is spelled with a capital “H”. (GITHUB) 🤖 Prompt for AI Agents |
||||||||||
| {field: "query", description: "Query to be executed. See [mergestat-lite](https://github.com/mergestat/mergestat-lite) for syntax", scheme: 'string', required: true}, | ||||||||||
| ]}/> | ||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ sidebar_custom_props: | |
|
|
||
| # <Icon name="http"/> HTTP | ||
|
|
||
| <!-- Source: modules/canary-checker/api/v1/checks.go:116#HTTPCheck --> | ||
| <!-- Source: modules/canary-checker/api/v1/checks.go#HTTPCheck --> | ||
|
|
||
| This check performs queries on HTTP to monitor their activity. | ||
|
|
||
|
|
@@ -30,7 +30,7 @@ This check performs queries on HTTP to monitor their activity. | |
| {field: "responseJSONContent", description: "Deprecated: Use expr and jsonpath function", scheme: "JSONCheck", deprecated: true}, | ||
| {field: "thresholdMillis", description: "Maximum duration in milliseconds for the HTTP request. It will fail the check if it takes longer", default: 5000, scheme: "int"}, | ||
| {field: "maxSSLExpiry", description: <>Maximum number of days until the SSL Certificate expires<br/>Equivalent to <code>test.expr: sslAge < Age("7d")</code></>, scheme: "int"}, | ||
| {field: "envVars", description: "Setup environment variables that are accessible while templating", scheme: "[]EnvVar"}, | ||
| {field: "env", description: "Environment variables that are accessible while templating", scheme: "[]EnvVar"}, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update the Template Body Variables section to use 🤖 Prompt for AI Agents |
||
| {field: "ntlm", description: "When set to true will authenticate using NTLM v1 protocol", scheme: "bool"}, | ||
| {field: "ntlmv2", description: "When set to true will authenticate using NTLM v2 protocol", scheme: "bool"}, | ||
| {field: "crawl", description: "Crawl configuration for following links", scheme: "[Crawl](#crawl-configuration)"}, | ||
|
|
@@ -43,7 +43,7 @@ This check performs queries on HTTP to monitor their activity. | |
| {field: "ca", description: "PEM encoded certificate of the CA to verify the server certificate", scheme: "EnvVar"}, | ||
| {field: "cert", description: "PEM encoded client certificate", scheme: "EnvVar"}, | ||
| {field: "key", description: "PEM encoded client private key", scheme: "EnvVar"}, | ||
| {field: "handshakeTimeout", description: "Timeout for SSL handshake (defaults to 10 seconds)", scheme: "int"}, | ||
| {field: "handshakeTimeout", description: "Timeout for SSL handshake (defaults to 10 seconds)", scheme: "Duration"}, | ||
| {field: "insecureSkipVerify", description: "Controls whether a client verifies the server's certificate chain and host name", scheme: "bool"} | ||
| ]}/> | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a top-level heading as the first line.
Markdownlint MD041 expects the first line to be an H1; start with a
#heading before the body text.As per coding guidelines, run
make fmt/make lintto catch this.🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
1-1: First line in a file should be a top-level heading
(MD041, first-line-heading, first-line-h1)
🤖 Prompt for AI Agents