Fix: do not subtract headerSize from dataSize#6
Open
borsanza wants to merge 1 commit intofixmycode:masterfrom
Open
Fix: do not subtract headerSize from dataSize#6borsanza wants to merge 1 commit intofixmycode:masterfrom
borsanza wants to merge 1 commit intofixmycode:masterfrom
Conversation
Author
|
How to reproduce the issue: dataSize = 2000 With the original code, the fragments generated are: With this fix, you get: Cómo reproducir el problema: dataSize = 2000 Con el código original, los fragmentos generados son: Con la corrección, se obtiene: |
Author
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi Pablo,
I noticed a small issue in the fragmentation logic: the remaining variable incorrectly subtracts the header size from the payload, which results in undercounting the actual data to be sent.
This pull request fixes that by assigning dataSize directly to remaining, as the header size is already handled separately in each fragment.
Thanks for the great tool!
Hola Pablo,
He detectado un pequeño error en la lógica de fragmentación: la variable remaining resta incorrectamente el tamaño de la cabecera, lo que hace que se envíen menos datos de los necesarios.
Este pull request lo corrige asignando directamente dataSize a remaining, ya que el tamaño de la cabecera ya se descuenta correctamente en cada fragmento.
¡Gracias por esta herramienta tan útil!