Skip to content

Comments

Add parallel[match] marker#31

Merged
connorjward merged 12 commits intomainfrom
connorjward/parallel-same-marker
Nov 21, 2025
Merged

Add parallel[match] marker#31
connorjward merged 12 commits intomainfrom
connorjward/parallel-same-marker

Conversation

@connorjward
Copy link
Collaborator

@connorjward connorjward commented Nov 21, 2025

Basically

$ mpiexec -n 3 pytest tests -m parallel[match]  # match parallel[3] tests
$ mpiexec -n 2 pytest tests -m parallel[match]  # match parallel[2] tests

Happy to be bikeshedded. Unfortunately -m parallel[?] and -m parallel[#] break bash.

@JHopeCollins
Copy link
Member

JHopeCollins commented Nov 21, 2025

Thanks for doing this, I'd completely forgotten about this!

The implementation looks fine.
Bike shedding incoming: what about parallel[.]?

Edit: . might be annoying if we want to query commands with grep/sed later.

FWIW I prefer parallel[match] to parallel[same], but really either one is fine

@wence-
Copy link

wence- commented Nov 21, 2025

Happy to be bikeshedded. Unfortunately -m parallel[?], -m parallel[#] and -m parallel[?] all break bash.

-m 'parallel[?]'

(i.e. with single quotes).

But that's probably not very discoverable

@connorjward
Copy link
Collaborator Author

I find it annoying to have to put quotes in. I don't particularly like same. Just need more suggestions. Annoyingly the tests that run fine locally are failing with

[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59

Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the main README too please?

@connorjward
Copy link
Collaborator Author

I find it annoying to have to put quotes in. I don't particularly like same. Just need more suggestions. Annoyingly the tests that run fine locally are failing with

[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03113] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_EXISTS in file common/pmix_iof.c at line 840
[Mac-1763733344719.local:03116] PMIX ERROR: PMIX_ERR_IOF_FAILURE in file iof_hnp_read.c at line 59

I may have a workaround...

@connorjward connorjward changed the title Add parallel[same] marker Add parallel[match] marker Nov 21, 2025
Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connorjward connorjward merged commit cc86767 into main Nov 21, 2025
25 checks passed
@connorjward connorjward deleted the connorjward/parallel-same-marker branch November 21, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants