feat: Parse screenName in ProvidedUserInfo#611
Open
sixstone-qq wants to merge 1 commit intofirebase:devfrom
Open
feat: Parse screenName in ProvidedUserInfo#611sixstone-qq wants to merge 1 commit intofirebase:devfrom
sixstone-qq wants to merge 1 commit intofirebase:devfrom
Conversation
lahirumaramba
approved these changes
Apr 9, 2024
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you @sixstone-qq ! LGTM!
lahirumaramba
requested changes
Apr 9, 2024
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Reverting my review till we get approval from @pragatimodi
sixstone-qq
force-pushed
the
sixstone-qq/add-screen-name-get-user
branch
2 times, most recently
from
5da2b98 to
8a82f96
Compare
sixstone-qq
force-pushed
the
sixstone-qq/add-screen-name-get-user
branch
2 times, most recently
from
502f91e to
b77aea8
Compare
Author
|
@pragatimodi it would be great if you can take a look on it to merge it upstream? Thanks a lot for your help here. |
Contributor
|
@lahirumaramba would this need an API council approval? or do we have an approved proposal for this already? |
sixstone-qq
force-pushed
the
sixstone-qq/add-screen-name-get-user
branch
2 times, most recently
from
66aaf2b to
e76b863
Compare
Author
|
Any update on this? |
This is available when having multiple providers where it provides a screen name such as Twitter or GitHub. See https://cloud.google.com/identity-platform/docs/reference/rest/v1/ProviderUserInfo for details. It's available at endpoints like accounts.lookup or projects.queryAccounts Signed-off-by: Enrique J. Hernández <sixstone-qq@users.noreply.github.com>
sixstone-qq
force-pushed
the
sixstone-qq/add-screen-name-get-user
branch
from
e76b863 to
53f88a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
It tries to fix #610 .
Testing
Adapt existing mocked data.
API Changes
Adding a new public field to UserInfo only populated under ProvidedUserInfo that is available in public API