Conversation
|
Deploy is failing probably because I should have updated some index after changing file names, I'll leave that to you @yiannisbot. |
austinabell
left a comment
austinabell
left a comment
There was a problem hiding this comment.
Looks generally correct, just giving 2c because asked to
yiannisbot
left a comment
yiannisbot
left a comment
There was a problem hiding this comment.
Thanks for the update! A couple of suggestions inline. We'll also need to get the site to compile and change all references to BlockSync in the rest of the spec. But I can take care of that one of the following days.
Co-authored-by: Yiannis Psaras <52073247+yiannisbot@users.noreply.github.com>
| If not all Tipsets requested could be fetched, but the `Head` of the chain segment requested was successfully fetched (and potentially more contiguous Tipsets), then this is not considered an error and a `Partial` response code is returned. The node can continue extending the chain from the partial returned segment onwards. | ||
|
|
||
| ```go | ||
| type Request struct { |
There was a problem hiding this comment.
you can embed this struct directly from the code https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go#L48-L60 using https://github.com/filecoin-project/specs#embed
Example:
{{<embed src="https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go" lang="go" symbol="Request" title="Exchange Protocol Request">}}
This way its easier to keep in sync.
|
Can you rebase please ? |
4 participants
Updates names from filecoin-project/lotus#3624 and some protocol packet structure from filecoin-project/lotus#2715.
Closes #1171.