Fix #247 (crash when X11WindowDriver failed to get window properties)#291
Open
elipsitz wants to merge 1 commit intofikovnik:masterfrom
Open
Fix #247 (crash when X11WindowDriver failed to get window properties)#291elipsitz wants to merge 1 commit intofikovnik:masterfrom
elipsitz wants to merge 1 commit intofikovnik:masterfrom
Conversation
X11WindowDriver uses `XGetWindowPropertyRef` to get a reference to the properties of the active window. If this fails, however, the outer function findFocusedWindow does not return "NO" to indicate failure, because the result of the inner block is ignored. This change makes sure findFocusedWindow returns "NO" if the inner block returns "NO".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X11WindowDriver uses
XGetWindowPropertyRefto get a referenceto the properties of the active window. If this fails, however,
the outer function findFocusedWindow does not return "NO" to
indicate failure, because the result of the inner block is
ignored. This change makes sure findFocusedWindow returns "NO" if the
inner block returns "NO".
Reproduce/test by using a GTK window, like sylpheed as suggested in the window, or this ginput/matplotlib Python script:
Trying to use ShiftIt on the window still won't work, but ShiftIt will no longer crash.
Fixes #247 .