Add config options for elm compilation#9
Open
CreggHancock wants to merge 1 commit intofeedbackone:mainfrom
Open
Add config options for elm compilation#9CreggHancock wants to merge 1 commit intofeedbackone:mainfrom
CreggHancock wants to merge 1 commit intofeedbackone:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves both #7 and #8
Added a config options type that can be expanded further with more options later down the line. For now I added what was needed to resolve both issues above as well as a debug options and a pathToElm option for where your elm executable is located option so that can be configured similarly to the node-elm-compiler.
I remembered to run biome format this time so hopefully we won't have any issues there, but I did notice that biome formatted the package.json that I didn't even touch so hopefully there are no issues there.
If you want any adjustments or have other config options you'd like added just let me know! Thanks!