chore: refactor version code calculation#368
Closed
m1sterc001guy wants to merge 1 commit intofedimint:masterfrom
Closed
chore: refactor version code calculation#368m1sterc001guy wants to merge 1 commit intofedimint:masterfrom
m1sterc001guy wants to merge 1 commit intofedimint:masterfrom
Conversation
m1sterc001guy
force-pushed
the
fdroid2
branch
from
d546477 to
436e8db
Compare
m1sterc001guy
commented
Feb 21, 2026
| @@ -0,0 +1,98 @@ | |||
| #!/usr/bin/env bash | |||
Collaborator
Author
There was a problem hiding this comment.
This script should also update the build.gradle.kts file
| sed -i "s/^version = \".*\"/version = \"$VERSION\"/" "$PROJECT_ROOT/rust/ecashapp/Cargo.toml" | ||
| echo "Updated Cargo.toml → version: $VERSION" | ||
|
|
||
| # Add appstream release entry |
Member
There was a problem hiding this comment.
nit: We're not in any official linux app stores (e.g. Flathub), but if later this ends up in an app store we probably don't want any of the RCs to show up, just the final release. No biggie for now though.
I think the only impact of having the RCs now is if a user looks at the AppImage they'll see a version history with RCs.
| echo "Updated appstream → release $VERSION ($RELEASE_DATE)" | ||
|
|
||
| # Commit and tag | ||
| git -C "$PROJECT_ROOT" add pubspec.yaml rust/ecashapp/Cargo.toml "$APPSTREAM_FILE" |
Member
There was a problem hiding this comment.
We'll also want to do something like
cargo check --manifest-path rust/ecashapp/Cargo.toml --target-dir rust/ecashapp/target
and make sure the Cargo.lock is included.
For reference, this is the diff for a previous version bump
ecash-app releases/v0.5 ❄ ❯ git show 1e5518f2b0cb69b9cfc30af64d89a8f542903e90
commit 1e5518f2b0cb69b9cfc30af64d89a8f542903e90 (HEAD -> releases/v0.5, tag: v0.5.0-rc.4, upstream/releases/v0.5)
Author: Brad Stachurski <bradley.stachurski@gmail.com>
Date: Thu Feb 12 12:37:47 2026 -0700
chore: bump version to v0.5.0-rc.4
diff --git a/pubspec.yaml b/pubspec.yaml
index 0ee0922..5635728 100644
--- a/pubspec.yaml
+++ b/pubspec.yaml
@@ -1,7 +1,7 @@
name: ecashapp
description: "A Fedimint Wallet"
publish_to: 'none'
-version: 0.5.0-rc.3
+version: 0.5.0-rc.4
environment:
sdk: ^3.7.2
diff --git a/rust/ecashapp/Cargo.lock b/rust/ecashapp/Cargo.lock
index 02a219b..916d700 100644
--- a/rust/ecashapp/Cargo.lock
+++ b/rust/ecashapp/Cargo.lock
@@ -1280,7 +1280,7 @@ checksum = "d0881ea181b1df73ff77ffaaf9c7544ecc11e82fba9b5f27b262a3c73a332555"
[[package]]
name = "ecashapp"
-version = "0.5.0-rc.3"
+version = "0.5.0-rc.4"
dependencies = [
"anyhow",
"async-stream",
diff --git a/rust/ecashapp/Cargo.toml b/rust/ecashapp/Cargo.toml
index b91827c..9091d94 100644
--- a/rust/ecashapp/Cargo.toml
+++ b/rust/ecashapp/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "ecashapp"
-version = "0.5.0-rc.3"
+version = "0.5.0-rc.4"
edition = "2021"
[lib]| # Commit and tag | ||
| git -C "$PROJECT_ROOT" add pubspec.yaml rust/ecashapp/Cargo.toml "$APPSTREAM_FILE" | ||
| git -C "$PROJECT_ROOT" commit -m "chore: bump version to $TAG" | ||
| git -C "$PROJECT_ROOT" tag "$TAG" |
Member
There was a problem hiding this comment.
Let's still sign tags with git tag -a -s
Collaborator
Author
|
Closing for #384. I've incorporated the feedback over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the version code calculation and adds a
release.shscript so that the releases branch will have the version code inpubspec.ymlMy preference would be to backport this to the
v0.5branch after thev0.5.0release and test with thev0.5.1release candidates.