Basic Tutorial (Deno): make it easier to specify other port #551
Conversation
Summary of ChangesHello @saerdnaer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the basic Deno tutorial to provide guidance on specifying a different port for the server. The change addresses scenarios where the default port 8000 might already be in use, making the tutorial more robust and user-friendly by explicitly showing a port configuration in the example code. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
issues-auto-labeler
bot
added
component/build
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to make the port number in the Deno tutorial explicit. However, the current change incorrectly passes the port to the Response constructor, which is not valid. The port should be specified in the Deno.serve function's options. I've provided a suggestion to fix this.
When port 8000 is already in use, make it easier for users of the tutorial to change it to an different port
saerdnaer
changed the title
| async (request) => { | ||
| const url = new URL(request.url); | ||
| // The home page: | ||
| if (url.pathname === "/") { | ||
| const followers: string[] = []; | ||
| for await (const entry of kv.list<string>({ prefix: ["followers"] })) { | ||
| if (followers.includes(entry.value)) continue; | ||
| followers.push(entry.value); | ||
| } | ||
| return new Response( | ||
| `<ul>${followers.map((f) => `<li>${f}</li>`)}</ul>`, | ||
| { | ||
| headers: { "Content-Type": "text/html; charset=utf-8" }, | ||
| }, | ||
| ); | ||
| } | ||
|
|
||
| // The federation-related requests are handled by the Federation object: | ||
| return await federation.fetch(request, { contextData: undefined }); | ||
| }); |
There was a problem hiding this comment.
I think these lines should be one-level more indented?
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
3 participants
When port 8000 is already in use, make it easier for users of the tutorial to change it to an different port