feat: Unified Client

[AmaseCocoa]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @AmaseCocoa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a foundational set of types and classes for a unified client, abstracting away the differences between synchronous (httpx) and asynchronous (aiohttp) HTTP response objects. By providing a common interface for response handling, including direct parsing into ActivityPub models, it aims to streamline client development and improve code maintainability.

Highlights

• Unified Response Abstraction: Introduced UnifiedResponse and UnifiedResponseAsync classes to provide a consistent interface for handling responses from httpx (synchronous) and aiohttp (asynchronous) libraries.
• ActivityPub Model Parsing: Both unified response classes include a parse method that automatically loads the response body into an ActivityPubModel using apmodel.load.
• Type Safety with Protocols: Defined a Response protocol and UnifiedContextManager protocol to ensure type consistency and enable generic handling of different HTTP client responses.

Changelog

• src/apkit/client/types.py
  • Added new file to define core types for a unified client.
  • Introduced Response protocol for generic HTTP response handling.
  • Implemented UnifiedResponse for httpx.Response and UnifiedResponseAsync for aiohttp.ClientResponse.
  • Included UnifiedContextManager protocol for consistent resource management.
  • Provided methods for status, headers, JSON parsing, and ActivityPub model loading.

Activity

• The pull request was created by AmaseCocoa.
• No further human activity (comments, reviews, or updates) has been recorded since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

❌ Patch coverage is 56.90608% with 234 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/apkit/client/base/context.py	30.92%	67 Missing ⚠️
src/apkit/client/methods/post.py	30.61%	34 Missing ⚠️
src/apkit/client/models.py	75.53%	31 Missing and 3 partials ⚠️
src/apkit/client/_common.py	27.27%	32 Missing ⚠️
src/apkit/client/methods/get.py	31.25%	22 Missing ⚠️
src/apkit/client/types.py	56.86%	22 Missing ⚠️
src/apkit/helper/host_meta.py	86.81%	9 Missing and 3 partials ⚠️
src/apkit/client/client.py	71.87%	7 Missing and 2 partials ⚠️
src/apkit/server/types.py	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[gemini-code-assist]

Code Review

This pull request introduces a unified client interface with response wrappers for both synchronous (httpx) and asynchronous (aiohttp) clients. The implementation has a few critical issues related to infinite recursion in the json methods of the response wrappers, which would cause runtime errors. I've also pointed out some dead code that can be simplified. Addressing these points will ensure the new client works as expected.