Skip to content

Refactor biology module: Replace panics with Result and enforce safety#618

Closed
fderuiter wants to merge 1 commit intomainfrom
refactor-biology-safety-17291833803350719285
Closed

Refactor biology module: Replace panics with Result and enforce safety#618
fderuiter wants to merge 1 commit intomainfrom
refactor-biology-safety-17291833803350719285

Conversation

@fderuiter
Copy link
Owner

  • Introduced DiffusionError, SpatialDiffusionError, and MorphogenesisError using thiserror.
  • Updated DiffusionModel, SpatialDiffusion, and TuringSolverStrategy traits to return Result.
  • Updated FiniteDifference1D, FiniteDifference2D, and FusedEulerSolver to return proper errors on dimension mismatches instead of panicking or failing silently.
  • Updated TuringSystem::step to return Result.
  • Updated usage in OdeSystem::derivative_in_place implementations to expect success (maintaining trait contract).
  • Cleaned up unused imports and variables in several modules to address warnings.
  • Verified with cargo test and cargo check.

PR created automatically by Jules for task 17291833803350719285 started by @fderuiter

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter closed this Feb 27, 2026
@fderuiter fderuiter deleted the refactor-biology-safety-17291833803350719285 branch February 27, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant